WP-for-Church / Sermon-Manager

Sermon Manager for WordPress is the #1 plugin for churches who want to manage their sermons easily and missionally.
https://wordpress.org/plugins/sermon-manager-for-wordpress/
GNU General Public License v2.0
43 stars 35 forks source link

Use WP Authors #194

Open nikola3244 opened 6 years ago

nikola3244 commented 6 years ago

This should be thinked through, how to use authors in conjunction with preachers.

Quick idea: If preacher is not set, use author (what should we do with API response?)

scottdwest commented 6 years ago

Could we have a way of going into a Preachers profile and associating it with an existing Author (Or Creating a new one)? Sermon Manager then looks up that info and populates it if its there at time of publishing/saving, if no author is found is uses a default Author (perhaps not the poster).

nikola3244 commented 6 years ago

That's another cool idea :wink: :+1:

robertmain commented 6 years ago

Hmm, my thought is that it would be cool to spin church profiles off into another plugin entirely that could integrate with sermon manager. Then you could have profiles for people who aren't preachers but have a presence in the church like say vestry members or wardens (Episcopal Church)

nikola3244 commented 6 years ago

Alright, priority of this has changed. It's going to have to be done pretty soon. Preachers as taxonomy terms are going away for good, it will be just WordPress users (authors) as preachers.

This is so we could be 110% compliant with GDPR. With current implementation, we don't have mechanism for preachers to request removal of their data. (but if we use WordPress users, that data would automatically be deleted)

robertmain commented 6 years ago

That's insane. I can't create wp accounts for every preacher ever. That's partly why I wanted this plugin.

I would say it's outside the scope of this plugin to handle that and should be implemented by the website operator.

nikola3244 commented 6 years ago

Talked to couple more people, seems like contacting website operator by email would be enough. Complex topic.

Unfortunately, I am not a lawyer, so I don't know the exact answer

robertmain commented 6 years ago

I would say that the issues with creating user accounts for every preacher doesn't really make sense. At some point I think we should spin preachers off into a separate plugin and then building out profiles etc.

Also, a preacher having a user account doesn't really help if they don't know the credentials. If they're going to contact the site admin to get the credentials they may as well just ask for the data to be deleted

macbookandrew commented 6 years ago

As far as GDPR compliance goes, if we added an email address field to the preacher tax terms, we could hook into the standard exporter/eraser tools from WP core:

scottdwest commented 5 years ago

My theme pulls my Name and Bio information when displaying a Sermon, not the Preacher's info. I currently hide this information on the front end using CSS, this is very inconvenient. Hiding the info via CSS does not remove my name when the theme correctly (for every other WP post/page) uses rel="author" in the HTML. Just showing the WordPress author box in the back end (for those that want it) would be an acceptable compromise for now if there are no plans to merge Preachers with Authors longer term.

robertmain commented 5 years ago

@scottdwest, not sure how that would really change the behavior on the front end, since authors and preachers are stored in different places. In other words, the authors box in the back end is just going to list wp authors...

nikola3244 commented 5 years ago

@scottdwest Your theme is most likely not using Sermon Manager views for some reason. Is the option "Theme Compatibility" checked in Sermon Manager Settings -> Advanced? - If it is, try to uncheck it

There is no code in Sermon Manager for showing the sermon authors, we just show preachers if there are any: views/partials/content-sermon-archive.php

scottdwest commented 5 years ago

@robertmain I already have most of our preachers as authors, they also write blog posts. So using the already established method for attributing WordPress content would allow me to keep all our Ministers content on one Author page too.

@nikola3244 I don't need Sermon Manager to do anything different on the front end, just have the option that it does not hide the already existing Author Picker on the back end.

Being able to see the WordPress Author picker when creating a new sermon would allow me to choose anything other than my own details to be associated with the sermon and would be a better solution than the current implimentstion.

nikola3244 commented 5 years ago

@scottdwest I don't see why not to add it - so it's done. Just download the latest development code from here or here.

Tip: You might need to enable it first in "Screen Options".

scottdwest commented 5 years ago

@nikola3244 thanks for that.