WP-for-Church / Sermon-Manager

Sermon Manager for WordPress is the #1 plugin for churches who want to manage their sermons easily and missionally.
https://wordpress.org/plugins/sermon-manager-for-wordpress/
GNU General Public License v2.0
43 stars 35 forks source link

Pagination error #294

Open rjorel opened 2 years ago

rjorel commented 2 years ago

Hey,

For some unknown reason, sermon pagination stopped working a few months ago. To fix the issue on my website, I've removed

'add_args' => $add_args,

from paginate_links() here : https://github.com/WP-for-Church/Sermon-Manager/blob/d8ce547b67a75fa2e45ff5f4be8960da5ed11b7f/includes/class-sm-shortcodes.php#L1138-L1160

I guess it comes from a WP (and/or my theme) updates, because post_type query variable is added to pagination links, while it are is present in query URL.

For example, I get links of the form /predications/?post_type[0]=post&post_type[1]=page&post_type[2]=e-landing-page

I checked the reason of this add_args in Git history, so I guess it's important to keep it, but for now it leads to a bug. Should you consider removing it for a future release?

Regards.