search

WPAFC / afch

Yet another Articles for creation helper script -- ACTIVE DEVELOPMENT NO LONGER HAPPENS IN THIS REPOSITORY AND HAS MOVED TO
https://github.com/WPAFC/afch-rewrite
10 stars 3 forks source link

Too much paragraph spacing removed #154

Open Technical-13 opened 11 years ago

Technical-13 commented 11 years ago

http://enwp.org/index.php?diff=571779089 shows that the script is removing all of the empty lines in the diff which is causing all of the text to be smashed up into one ugly paragraph. Was reported to me on the #wikipedia-en-helpers channel of freenode by Huon if more information is need for some odd reason (the edit was made by @hasteur so I couldn't imagine more info from Huon being needed).

hasteur commented 11 years ago

Appears to work better now (https://en.wikipedia.org/w/index.php?title=Wikipedia_talk%3AArticles_for_creation%2FMonsterFest&diff=571870037&oldid=570717890)

Advanced to "Fixed in Dev" milestone as the Theo's Bot version does show improvement

theopolisme commented 11 years ago

Still broken after https://github.com/WPAFC/afch/commit/619980ca5cc23bca3ac000385a6a704676193e94

wikipedia-mabdul commented 11 years ago

see my edits at https://test.wikipedia.org/wiki/MediaWiki:Gadget-afchelper.js/submissions.js - commenting out many stuff until i find the bad regex... the 3 regexes I had in mind weren't the problem. sadly

wikipedia-mabdul commented 11 years ago

oh wow. theopolisme come online (chat)!

wikipedia-mabdul commented 11 years ago

for the case we have more problems, see a potential fix there: https://test.wikipedia.org/w/index.php?title=MediaWiki%3AGadget-afchelper.js%2Fsubmissions.js&diff=179326&oldid=179325

wikipedia-mabdul commented 11 years ago

dunno, but i believe this is fixed. (marking as "in develop")

if not: please provide diffs