FFU isn't working with official skin "modern"

[wikipedia-mabdul]

regarding to #186 I'm opening a new ticket.

In the last commits (code https://en.wikipedia.org/w/index.php?title=User%3ATheo%27s_Little_Bot%2Fafch%2Fafchelper.js%2Fffu.js&diff=574658136&oldid=574603620 ) the onchange() isn't added, see my debugger stuff

<h2>
<span class="mw-headline" id="Stockholm_Arlanda_Airport">Stockholm Arlanda Airport</span>
<span class="mw-editsection">
[
<a href="#ffu-review-1" sectionindex="2">Review request</a>
] 
<span class="mw-editsection-bracket">[</span>
<a href="/w/index.php?title=Wikipedia:Files_for_upload&action=edit&section=2" title="Edit section: Stockholm Arlanda Airport">edit</a>
<span class="mw-editsection-bracket">]</span>
</span>
</h2>

[theopolisme]

What are you talking about...? FFU loads using the latest version of the develop branch (try it out on enwiki @ WP:FFU...I copied and pasted code from develop branch into console and it worked exactly as intended)

@Technical-13 nice work on the additional menu options by the way!

[wikipedia-mabdul]

OK, just tested it in Safari. It works fine there, but in Opera nothing happens after clicking on 'review'.

(Updated subject; we should find it out what Opera breaks as this simply strange for ME as the debugger isn't stopping anywhere!)

[theopolisme]

Any console output? Error messages?

[wikipedia-mabdul]

just updated: no otherwise I would have fixed it already

[theopolisme]

Let me test it in Opera for Mac and see what happens.

[wikipedia-mabdul]

remember: opera 14+ is using blink (fork of webkit)

I'm using the Presto based Opera 12 (and won't switch - at least not the next two years :-p)

[theopolisme]

..why?

[wikipedia-mabdul]

because of the removed features...

don't ask. I don't like the new one.

I will find it out and maybe fixing it...

[theopolisme]

Yeah, works in latest version of Opera for Mac. Sorry, can't help you..

[wikipedia-mabdul]

BTW: your bot is now sysop ^^

[wikipedia-mabdul]

ok: the script works totally fine at test.wikipedia. I have no idea why it isn't working at enwp.

[theopolisme]

That's so weird. Maybe a gadget or user script you have enabled? Did you try using a test account? Would the script load then?

[wikipedia-mabdul]

it is a server problem. check VPT: server load is crazy. I will wait a day (or more, depend on my time) and then check it again...

[theopolisme]

@wikipedia-mabdul ping

[wikipedia-mabdul]

Just checked again. Still not working at enwp. I will try and analyse that LATER (could be WEEKS) as I'm very busy until end of November... So you won't see any new commits in near future. Maybe except the stuff in branch feature-addingcats

[wikipedia-mabdul]

are the WMF servers again stable?

[theopolisme]

No idea. Still very weird and implausible.

[wikipedia-mabdul]

so, this is a WILLCHECKLATER :-)

I still believe that any browser (opera) specific load isn't working. /me wonders who changed what and why. :-/

[theopolisme]

FFU works perfectly with latest versions of

• Safari
• Chrome
• Opera

on Mac.

I hate to say it but your problems with an antiquated browser don't really concern me...I shouldn't have to write code to deal with your refusual to adopt a modern browser. :p

[wikipedia-mabdul]

BTW: This is not working both on Mac and on Win.

I will test it using IE in a few minutes (I'm at work...)

err. I don't like the situation, too, but it is simply, well the browser is still supported! (Opera Software ASA is still providing security patches!)

[theopolisme]

Are you SURE it's not working? Are you using the Theo's Little Bot mirror?

[wikipedia-mabdul]

https://en.wikipedia.org/wiki/User:Mabdul/modern.js <-- says yes; the gadget was never used by the preferences. (lol)

BTW: one of the reasons I don't switch to a newer Opera version is: http://www.favbrowser.com/opera-real-bookmarks-is-not-our-priority/ (I do use bookmarks, although I don't access them, WHEN I do need them, I'm the lucky guy who knows where to search to get them!)

[theopolisme]

What is the console output when you click the [Review request] link? Is there any console output?

[wikipedia-mabdul]

nope. Come'on I'm not that stupid. no breakpoint waiting in ffu.js, no console output (except CSS stuff), no hint at all...

[theopolisme]

Hah, that's messed up. Run afcHelper_ffu_init(); in your console. Does the review panel pop up then? (trying to determine if issue is with the link or with the init() function)

[wikipedia-mabdul]

https://en.wikipedia.org/w/index.php?title=Wikipedia:Files for upload&useskin=vector both in IE10, but also using the "normal" url with my modern skin.

Actually with https://en.wikipedia.org/w/index.php?title=Wikipedia:Files for upload&useskin=vector there isn't even a review link; https://en.wikipedia.org/wiki/Wikipedia:Files_for_upload contains [Review request]; but nothing happens. checking console

[wikipedia-mabdul]

interesting: yes: opening afcHelper_ffu_init(); in IE10 and Opera12 debugger console, the review panel opens.

[wikipedia-mabdul]

updated the topic. Not Opera only issue any more -.-

[Technical-13]

Seems to work in O12.16 just fine for me.

[wikipedia-mabdul]

OK, but why (the hell) is it not working here? Testwp seems fine; IE10 is borked too.

Lemme try to use my public account wikignome

[Technical-13]

I don't have access to IE10 unfortunately... My Vista laptop uses IE7 and the University's computers are IE9.

[wikipedia-mabdul]

OK, that's strange. it has to be something with my personal user preferences. using wikignome and IE10 is working fine.

Wikignome has nearly nothing customized. so I will check what is causing these troubles...

[wikipedia-mabdul]

actually it has nothing to do with any user included scripts (so leaving it to gadgets and other magic stuff...) https://en.wikipedia.org/wiki/User:Mabdul/common.js https://en.wikipedia.org/wiki/User:Mabdul/modern.js

[theopolisme]

I bet it has something to do with the modern skin; it probably uses different ids/classes for the edit links (so the code to add a click handler doesn't work).

[theopolisme]

I was right. @wikipedia-mabdul, fixed! :)

From my commit message:

The modern skin does not use a bodyContent div, which was preventing the clicks on "Review request" from triggering anything. Changed to a more general selector.

[wikipedia-mabdul]

Updated subject. Confirmed: bug fixed. @theopolisme great job! SKIN change would be the last what I had checked...

[wikipedia-mabdul]

Actually iron out here the bugs helps us to use a similar code for AFC/R if we want.