WPAFC / afch

Yet another Articles for creation helper script -- ACTIVE DEVELOPMENT NO LONGER HAPPENS IN THIS REPOSITORY AND HAS MOVED TO
https://github.com/WPAFC/afch-rewrite
10 stars 3 forks source link

G13 eligible without G13 buttons #198

Closed Technical-13 closed 11 years ago

Technical-13 commented 11 years ago

See https://en.wikipedia.org/wiki/Wikipedia_talk:Articles_for_creation/Hebei_Vocational_College_of_Foreign_Languages which hasn't been edited in 20 months yet doesn't have tag as G13 button on reviewing...

theopolisme commented 11 years ago

it's because of the messed up afc template.

{{AFC submission|ts=20120102072036|D}}

Dup of #196; please continue to discuss there.

Technical-13 commented 11 years ago

Why is the script looking for how long ago the last edit is in the submission template instead of getting that information from the API? The only timestamps in the submission template are the submission timestamp and when applicable the decline timestamp, If it is looking at those, then there are a lot of drafts it thinks are eligible but aren't because users may have edited after the declination.

theopolisme commented 11 years ago

No, I think you've confused yourself... The script does query the API.

However, @hasteur told me back when this was first implemented that if the status of the template was "r" or "" (in other words, if it was currently submitted), the G13 button should be hidden -- and since it was unable to parse the template, I believe it defaulted to a "" status. This should really be discussed in #196.