WPBP / WordPress-Plugin-Boilerplate-Powered

Wordpress Plugin Boilerplate but Powered with examples and a generator!
https://wpbp.github.io/
GNU General Public License v3.0
793 stars 114 forks source link

[BUG] Integer ID-s for cmb2_metabox_form #162

Closed szepeviktor closed 4 years ago

szepeviktor commented 4 years ago
 ------ ----------------------------------------------------------------------------------
  Line   backend/views/settings-2.php
 ------ ----------------------------------------------------------------------------------
  32     Parameter #2 $object_id of function cmb2_metabox_form expects int, string given.
 ------ ----------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------
  Line   backend/views/settings.php
 ------ ----------------------------------------------------------------------------------
  258    Parameter #2 $object_id of function cmb2_metabox_form expects int, string given.
 ------ ----------------------------------------------------------------------------------

@Mte90 Could you redesign the call of cmb2_metabox_form() to give it an integer ID?

Mte90 commented 4 years ago

I am checking because seems that originally was a string and later that parameter moved to be a integer of the post id. I am doing some tests and I will update it.

Mte90 commented 4 years ago

Seems that there is an issue with the code of CMB2 https://github.com/CMB2/CMB2/issues/1365

Mte90 commented 4 years ago

The bug was fixed in the phpdoc of CMB2 so the next version will have the fix.