WPBP / WordPress-Plugin-Boilerplate-Powered

Wordpress Plugin Boilerplate but Powered with examples and a generator!
https://wpbp.github.io/
GNU General Public License v3.0
791 stars 114 forks source link

a better way of handling plugin generation (credits. @Ryvix) #231

Closed erikyo closed 1 year ago

erikyo commented 1 year ago

As suggested by @Ryvix there was some issue related the generation of the plugin zip file.

In order to fix the issues:

In order to test this PR, generate a plugin as usual, build the zip file using the "npm run plugin-zip" command, install it and then check if the a default block is available inside the "block editor"

fixes #230

erikyo commented 1 year ago

@Mte90 is it worth it to remove all the index.php located inside the ./assets/src/ folder? Since that folder should not be published I believe they are now a bit useless (as well as creating some unnecessary clutter)

Mte90 commented 1 year ago

It will not published if people don't copy the folder and upload it somewhere. I think that to cover all the cases is better to keep that index.php just for safety.