search

WPBP / WordPress-Plugin-Boilerplate-Powered

Wordpress Plugin Boilerplate but Powered with examples and a generator!
https://wpbp.github.io/
GNU General Public License v3.0
782 stars 116 forks source link

[Feature] Can we add assets/build/ to .gitignore? #244

Closed ronald2wing closed 1 month ago

ronald2wing commented 2 months ago

Is your feature request related to a problem? Please describe. These are dynamic files; there is no reason to store them in Git. Primarily they will be generated automatically after npm install. Or they can be auto-refresh with npm run start.

Describe the solution you'd like Add assets/build/ to .gitignore.

Describe alternatives you've considered Add assets/build/ to .gitignore by myself.

Additional context None.

Mte90 commented 1 month ago

There is already https://github.com/WPBP/WordPress-Plugin-Boilerplate-Powered/blob/master/.gitignore#L41

Maybe it isn't changed the plugin slug on the generator?

Mte90 commented 1 month ago

No with the generator the slug is changed, did you used the boilerplate with that?

ronald2wing commented 1 month ago

I see what happened. I only commit the plugin contents. Can we also ignore it without the plugin-name since the .gitignore file is inside the plugin?

I would also like to use Composer to install the plugin from a repository (e.g., when using Bedrock and packages). How can we do that?

Mte90 commented 1 month ago

I understand what is happening, the generator move the .gitignore so the path doens't works anymore. I am fixing.

About composer to install the plugin in the past someone asked too but I never used bedrock or composer to install plugin.

ronald2wing commented 1 month ago

Thank you for your hard work! Can we remove composer.lock from .gitignore? - *.lock

Mte90 commented 1 month ago

I prefer to leave there, there is people that don't want to commit the lock.

Maybe I can add an option to the plugin generator to remove it.

ronald2wing commented 1 month ago

That would be awesome. Thank you!

Mte90 commented 1 month ago

https://github.com/WPBP/WordPress-Plugin-Boilerplate-Powered/blob/master/.gitignore as I can see the composer.lock isn't there

ronald2wing commented 1 month ago

*.lock will also ignore composer.lock.

Mte90 commented 1 month ago

Implemented in the generator :-)

I am not sure when I will do a new release of the boilerplate.

ronald2wing commented 1 month ago

About composer to install the plugin in the past someone asked too but I never used bedrock or composer to install plugin.

Can I open a feature request in case someone wants this feature and is capable of implementing it?

Mte90 commented 1 month ago

Yeah sure, usually is just me working on this project so let's see.

ronald2wing commented 1 month ago

Yeah sure, usually is just me working on this project so let's see.

There are so many WP developers, but very few are working on development tools.