largo_home_icon does not output images with relative or protocol-agnostic URLs.

[benlk]

The regular expression here accepts the following:

https://therivardreport.com/wp-content/uploads/2016/06/Rivard-Report-Logo-Long-1-336x36.png
http://therivardreport.com/wp-content/uploads/2016/06/Rivard-Report-Logo-Long-1-336x36.png

but does not accept the following:

/wp-content/uploads/2016/06/Rivard-Report-Logo-Long-1-336x36.png
//therivardreport.com/wp-content/uploads/2016/06/Rivard-Report-Logo-Long-1-336x36.png

In cases where the saved URL is not accepted, the function silently outputs <i class="icon-home ' . esc_attr( $class ) . '"></i> where $class was passed to largo_home_icon()

Permanent fix

Change the regex. It's currently /^http(s)?\:\/\//

It should accept:

• urls starting with / (covers both absolute paths and protocol-agnostic paths)

Temporary fix for sites affected:

Add the domain name and protocol back in.

[rclations]

Since this function is only used in /partials/nav-sticky.php, I think we can remove the function altogether and integrate the code directly into the template for simplicity.

Steps needed on this ticket:

• [ ] Remove the preg_match if statement from the largo_home_icon() function - if we have a saved value for the field, we should use it.
• [ ] Replace the function calls in /partials/nav-sticky.php with the logic contained in the function.
• [ ] Remove the largo_home_icon() function from /inc/images.php.

[benlk]

Allow largo_home_icon to output images with relative or protocol-agnostic URLs