WPBuddy / largo

A WordPress framework for news websites. Finely-crafted by INN and expertly-honed and maintained by the technology team at WP Buddy.
http://largo.wpbuddy.co
GNU General Public License v2.0
170 stars 83 forks source link

Top term on single template below 529px overlaps header #1472

Open benlk opened 7 years ago

benlk commented 7 years ago

First reported in https://github.com/INN/umbrella-okwatch/issues/2

There's a weird positioning thing with the top tag on article pages: It's only an issue on those narrow media queries, so please put the fix there!

Affecting browsers < 529px wide:

body.normal.page article.page>header h5.top-tag,
body.normal.page article.post>header h5.top-tag,
body.normal.single-post article.page>header h5.top-tag,
body.normal.single-post article.post>header h5.top-tag {
    position: absolute;
    left: 0;
}

That's these lines: https://github.com/INN/largo/blob/v0.5.5.3/less/inc/single.less#L23-L27

Any fix should include a media query scoping that positioning to more than 529px, effectively the inverse of https://github.com/INN/umbrella-okwatch/commit/e7b8826d6b4e49956bf6de4ff29486329a43d6cb

I believe this is caused by an @media @mobile query that contains styles affecting the spacing og the header, possibly https://github.com/INN/largo/blob/v0.5.5.3/less/inc/single.less#L122-L124

benlk commented 5 years ago

Why is the thing weirdly positioned in the first place? Wouldn't normal block layout work?

benlk commented 5 years ago

simplify styles for top term on article pages