Should largo_byline require an explicit post to be specified?

benlk commented 6 years ago

This would need to be undertaken in steps:

[x] in one release of Largo: 0.6
- [x] add warning output on WP_DEBUG|LARGO_DEBUG that notifies devs that largo_byline is being called without an express post ID or post object
- [x] note intent to deprecate and provide docs on how to call it with a post ID or WP_Post object
[ ] in the subsequent release: 0.7
- [ ] output the error message in the actual byline.
- [ ] notes for changelog

This would lessen the chance that we have bylines that don't match stories when building custom partials.

benlk commented 6 years ago

https://github.com/INN/largo/pull/1561 merged in 0.6, so the next stage of deprecation can be in 0.7.

benlk commented 5 years ago

benlk commented 5 years ago

Adding the error message to the actual byline should be done in the else section of this chunk of code:

WPBuddy / largo