search

WPBuddy / largo

A WordPress framework for news websites. Finely-crafted by INN and expertly-honed and maintained by the technology team at WP Buddy.
http://largo.wpbuddy.co
GNU General Public License v2.0
171 stars 83 forks source link

PHP error on endocrine disruptors landing page #266

Closed kategolden closed 10 years ago

kategolden commented 10 years ago

http://wcij.wpengine.com/series/endocrine-disruptors/

text from top: Project: Endocrine Disruptors

Notice: Undefined variable: out in /nas/wp/www/cluster-2755/wcij/wp-content/themes/largo/inc/post-tags.php on line 98

Notice: Undefined variable: out in /nas/wp/www/cluster-2755/wcij/wp-content/themes/largo/inc/post-tags.php on line 105

aschweigert commented 10 years ago

Series landing pages don't have the tag taxonomy enabled so that's intentional. These other issues look like they're due to assigning more than one author to a series landing page, we'll have to look into why this isn't working.

Also, @kategolden just FYI - PHP notices are typically minor issues that many people wouldn't even bother fixing. We try to eliminate them just to improve overall code quality but PHP warnings are typically more serious and something that we do need to resolve. The only reason the notices are displayed right now is for debugging but once the site is live they will be turned off and just added to the PHP error logs but not displayed on either the front end or the dashboard.

kategolden commented 10 years ago

Great. I generally have no idea what these errors mean, so I was adding it in case it was important. k

On Fri, May 30, 2014 at 10:32 AM, Adam Schweigert notifications@github.com wrote:

Series landing pages don't have the tag taxonomy enabled so that's intentional. These other issues look like they're due to assigning more than one author to a series landing page, we'll have to look into why this isn't working.

Also, @kategolden https://github.com/kategolden just FYI - PHP notices are typically minor issues that many people wouldn't even bother fixing. We try to eliminate them just to improve overall code quality but PHP warnings are typically more serious and something that we do need to resolve. The only reason the notices are displayed right now is for debugging but once the site is live they will be turned off and just added to the PHP error logs but not displayed on either the front end or the dashboard.

— Reply to this email directly or view it on GitHub https://github.com/INN/Largo/issues/266#issuecomment-44664317.

Reporter/Multimedia Director Wisconsin Center for Investigative Journalism www.wisconsinwatch.org 608-262-3642

aschweigert commented 10 years ago

nope, happens when no author is set for a series landing page. seems like and edge case but we should probably have a fall through to just output nothing/not show the byline when this is the case.