search

WPCV / wpcv-woo-civi-integration

A WordPress plugin that creates CiviCRM Contributions, Memberships and Participants from WordCommerce Orders and keeps WordCommerce Customer Accounts in sync with CiviCRM Contact data.
GNU Affero General Public License v3.0
4 stars 8 forks source link

Fixed saving issue with variation product membership and participants #35

Closed lukeyangjma closed 2 years ago

lukeyangjma commented 2 years ago

When creating a product with variations and setting the CiviCRM Entity to 'Membership' or 'Participant', setting the Membership Type or Participant Role within the variation tab of the product did not save after clicking the 'Save changes' button. This PR fixes the parameter order of the variation_save functions used to save the membership type and participant role. The action to save participants did not exist and was also added.

Edzelopez commented 2 years ago

@christianwach we noticed this bug while working on functionality that would improve the migration script that runs when you are switching from the old version of the plugin to this newer one.

christianwach commented 2 years ago

Awesome, thanks @lukeyangjma @Edzelopez