search

WPCV / wpcv-woo-civi-integration

A WordPress plugin that creates CiviCRM Contributions, Memberships and Participants from WordCommerce Orders and keeps WordCommerce Customer Accounts in sync with CiviCRM Contact data.
GNU Affero General Public License v3.0
4 stars 8 forks source link

Don't produce a fatal error when attempting to activate this plugin before Woocommerce #58

Closed cdhassell closed 6 months ago

cdhassell commented 8 months ago

The behavior of this plugin is odd when handling the absence of the Woocommerce dependency. If I am testing a site and disable all plugins, and then re-enable them, this plugin (coming alphabetically before Woocommerce) hits a dependency error. This is okay, but it produces a fatal error and stops all further activations. So I must manually re-activate all other plugins except this one, so it can be activated last. This seems unnecessarily difficult - it would be better for this plugin to simply skip its own activation with a warning flag and then allow the process for other plugins to continue. Thanks.

christianwach commented 6 months ago

@cdhassell I agree and have removed the heavy-handed dependency check with 2dbcb2b87ad6c38bd3ac575dd94e38b9343384dd in my development branch. It will be in v3.1.2 when that gets released.