WPChill / download-monitor

A WordPress plugin which provides an intuitive UI for uploading and managing downloadable files (including support for multiple versions), inserting download links into posts & logging downloads.
http://wordpress.org/extend/plugins/download-monitor/
262 stars 117 forks source link

Translated string function missing #1257

Open reuhno opened 1 year ago

reuhno commented 1 year ago

Describe the bug some strings are not marked as translatable. For example, with the extension "email lock", the placeholder "Email Adress" is set as raw text in plugin.


    public function change_button_to_page_addon_list( $value , $download ) {
        $access_manager = new DLM_EL_Access_Manager();
        if ( false == $access_manager->check_access( true, $download, null ) ) {
        $value = '<td>';
            $value .= '<form method="post" action="' . $download->get_the_download_link() . '">';
                $value .= '<input type="email" name="dlm-email-lock-email" class="dlm-email-lock-email" value="" placeholder="Email Address" required="true"/>';
                $value .= '<input type="submit" name="Submit" class="dlm-email-lock-submit" value="Download"/>';
            $value .= '</form>';
        $value .= '</td>';
        }

        return $value;
    }
}

Could you integrate the placeholder text with the native wp translation functions? (() or e())

Thanks in advance

reuhno commented 1 year ago

I saw another string in /dlm-email-lock/templates/download-email-lock-optin.php

<p class="dlm-email-lock-optin-field-submit">
        <input type="submit" <?php echo ( $mx_record ) ? 'disabled="disabled"' : '';  ?> name="Submit" class="dlm-email-lock-submit <?php echo ( $mx_record ) ? 'disabled' : '';  ?>" value="Download"/>
    </p>

"Download" should be translatable ;)