WPChill / modula-lite

https://wordpress.org/plugins/modula-best-grid-gallery/
GNU General Public License v3.0
18 stars 9 forks source link

images are on top of each other in Elementor #468

Closed mplusb closed 3 years ago

mplusb commented 3 years ago

Describe the bug when you add the Modula widget in Elementor editor it stacks images one on top of the other. It should look like this: https://gyazo.com/1e540a78e502a1775ba26b19210524cc But it looks like this: https://gyazo.com/5e013be24761b8537ba03c38744128af

To Reproduce Steps to reproduce the behavior: Go to Pages > edit with Elementor > add Modula widget > see issue

Used versions

Florin415 commented 3 years ago

I tested this and indeed there seems to be a problem , on mozila firefox it will work properly but on chrome it will not as you can see in these screenshots : Chrome : https://prnt.sc/w4k612 Opera:https://prnt.sc/w4kasl Edge : https://prnt.sc/w4kbha Mozilla : https://prnt.sc/w4k9yd

Also there seems to be a problem in Modula Albums : Chrome : https://prnt.sc/w4klrw Firefox : https://prnt.sc/w4kmav

Used all the above plugins from : https://wp-modula.com/

razvanaldea89 commented 3 years ago

This seems to be an issue with the jQuery Migrate. Tested with jQuery Migrate Helper plugin and seems to work fine.

Florin415 commented 3 years ago

To achieve this temporary solution mentioned by @razvanaldea89 , after you install the plugin go to https://prnt.sc/w582wn and choose https://prnt.sc/w5838b

cristianraiber commented 3 years ago

@razvanaldea89 - we shouldn't be relying on jQuery Migrate Helper. We should fix our own product. cc @giucu91

razvanaldea89 commented 3 years ago

@cristianraiber was trying to tell about the source of the problem. That is for sure not a solution, we should fix it

giucu91 commented 3 years ago

@razvanaldea89 jQuery Migrate is bundled in WP 5.6 so installing jQuery Migrate Helper wont fix the problem.

The problem is this : https://github.com/elementor/elementor/issues/6756

The solution is this : https://github.com/metafizzy/flickity/pull/900/files

Florin415 commented 3 years ago

Tested with Modula lite + Elementor now it's working . I tried to see if it works with albums as well but could not create albums for the moment and I opened for that this issue : https://github.com/WPChill/modula-lite/issues/473