WPChill / strong-testimonials

A WordPress plugin for client testimonials.
GNU General Public License v3.0
21 stars 11 forks source link

Excerpt not hidden when expanded due to JS error #357

Closed Bogardo closed 1 year ago

Bogardo commented 1 year ago

Describe the bug On a view with Mode Display when either the automatic or manual excerpt is enabled, the 'Read more' button shows the full content but keeps the existing excerpt, resulting in duplicate text. This seems to be caused by a Javascript error:

Uncaught TypeError: Cannot set properties of undefined (setting 'display') 
    at HTMLDocument.<anonymous> (readmore.min.jsver=3.0.2:1:1286)

To Reproduce Steps to reproduce the behavior:

  1. Create a testimonial with some (long) content

  2. Create a view with the following settings:

    image

    With style: Default, image on left, light theme, with a quote symbol in the heading Layout: normal Background: inherit from theme Font color: inherit from theme

  3. Place view on Page with shortcode

  4. Open page with testimonials

  5. Click on 'Read more' button

  6. See both excerpt and the content of the testimonial

Expected behavior When clicking on the 'Read more' button the excerpt should be hidden and replaced with the full content. Due to the JS error the excerpt is not hidden.

Demo gif testimonial

Used versions

TeoAlex commented 1 year ago

The issue was fixed here https://github.com/WPChill/strong-testimonials/commit/187eaeda5f99b1e86855ebe631d5cc6182ac5722 and released with 3.1.0 update.