WPCloudDeploy / wp-cloud-deploy

WPCloudDeploy is a WordPress plugin that allows you to easily deploy and manage your own dedicated high-performance WordPress servers and sites at any cloud server provider.
https://wpclouddeploy.com
Other
91 stars 42 forks source link

Woo Subscriptions V 6.0+ breaks WPCD #101

Closed unakriti closed 3 months ago

unakriti commented 3 months ago

Hi,

I am seeing a weird issue that the WPCD public pages break inside the editor specifically while editing /cloud-apps and /cloud-servers/ . The error message is "Updating failed. This is not a valid JSON response". On the frontend, the UI is broken with a message "There has been a critical error on the website" . Here's a screenshot

WPCD Woo Subscription Issue UI Breaks Screenshot from 2024-06-17 14-13-09

The issue goes away when I degrade the WooCommerce Subscriptions extension to Version 6.0.

Issue persists with WPCD Version/s 5.8 and 5.7

Kind regards,

SuperHondo commented 3 months ago
image

https://www.herdegenfuneralhome.com/obituaries/Nigel-Rasheed-Bahadur?obId=31617195

Nigel Bahadur no more ... its shocking. I wonder how would the WPCLOUDdeploy survive now :(

unakriti commented 3 months ago
image

https://www.herdegenfuneralhome.com/obituaries/Nigel-Rasheed-Bahadur?obId=31617195

Nigel Bahadur no more ... its shocking. I wonder how would the WPCLOUDdeploy survive now :(

Sad to read this. RIP Nigel.

sunxiyuan commented 3 months ago

You need to open debug mode and post the error output of this page

unakriti commented 3 months ago

You need to open debug mode and post the error output of this page

Thanks much @sunxiyuan .

I will park this issue for now - until the future of WPCD becomes clear.

Kind regards,

qvdrei commented 3 months ago

What will happen to WPCD now? I really want to get involved and continue to develop and market this product. I'm willing to hire developers and create a strategy to market it to broad market.

eslam-dev commented 3 months ago

Hello,

The issue seems to be due to WooCommerce Subscriptions. To solve the problem, navigate to the file at the following path: woocommerce-subscriptions/vendor/woocommerce/subscriptions-core/includes/wcs-compatibility-functions.php and modify the function named wcs_get_page_screen_id to return $object_type. Alternatively, you can replace it entirely with:

function wcs_get_page_screen_id( $object_type ) {
    return $object_type;
}

until a new version of WooCommerce Subscriptions is released that supports the latest version of WooCommerce.

We will continue updating the WPCD plugin on another repository. You can follow us and send any issues you encounter https://github.com/wpmts/wp-cloud-deploy

qvdrei commented 3 months ago

Hello,

The issue seems to be due to WooCommerce Subscriptions. To solve the problem, navigate to the file at the following path: woocommerce-subscriptions/vendor/woocommerce/subscriptions-core/includes/wcs-compatibility-functions.php and modify the function named wcs_get_page_screen_id to return $object_type. Alternatively, you can replace it entirely with:

function wcs_get_page_screen_id( $object_type ) {
  return $object_type;
}

until a new version of WooCommerce Subscriptions is released that supports the latest version of WooCommerce.

We will continue updating the WPCD plugin on another repository. You can follow us and send any issues you encounter https://github.com/wpmts/wp-cloud-deploy

Great! Are you from Nigel's team? Do you know anyone from Nigel's team? Do you have acces to the Multi-Tenancy Module Or even the latest release "Momentum"? I want to join the project and market it to broad audience.

eslam-dev commented 3 months ago

@qvdrei We are not part of Nigel's team, but we did develop the multi-tenant feature with him in the beginning and also developed our own plugin for multi-tenancy And tested it with a network of +9k sites and 4 servers

nightcrawler123 commented 3 months ago

@qvdrei @eslam-dev this is modifying woo sub plugin! not the wpcd plugin. but it works i guess.

qvdrei commented 3 months ago

@eslam-dev

Hmm .. did Nigel work alone? He asked for help from contractors like you? If he was a one man band, damn, he developed a lot alone...

Could you also tell me more about the multi-tenant plugin that you developed?

eslam-dev commented 3 months ago

@nightcrawler123 The issue occurs due to a condition inside the Woo Sub plugin.

eslam-dev commented 3 months ago

@qvdrei Yes, he probably was working alone with the help of some contributors.

There is an additional plugin that enables multi-tenancy The idea is slightly different from WPCD

Simple example

our plugin creates a version control system on the internal server, so we don't issue a release that includes the entire WordPress as it is in WPCD.

We upload the versions inside the plugins or themes folder, and you can change the version from your admin panel or through WPCD. For example, in the versioning system for the WooCommerce plugin:

There is a folder named plugins, inside it a folder named woocommerce, and inside that folder are the versions like 9.0.0, 8.0.0, and so on. I can set the main version that runs on all sites and exclude the sites that have a custom version. For instance, if I change a site's version to 8.0.0, when an update is uploaded, it remains the same and does not change, but any other site that doesn't have a custom version specified will be updated.


  |__ plugins
    |__ woocommerce/
        |__  main/
        |__ 9.0.0/
        |__ 8.0.0/