search

WPClubManager / wp-club-manager

Create and manage a sports club or league website quickly and easily using WordPress.
https://wpclubmanager.com
Other
33 stars 13 forks source link

Update admin.css #25

Closed DaveyJake closed 4 years ago

DaveyJake commented 4 years ago

Hey mate,

I was trying to merge a different branch but it would let me exclude any previous PRs that I had submitted.

Ultimately, the commit I was trying to submit fixes the admin.css file, particularly the League Table Display columns from touching the edge of its container.

The SHA for the commit I wanted to submit is 3df7bf7415655788f0ce0f5529c85a1808153bb7.

Moving forward, should I just create a separate branch based on your dev branch or should keep submitting PRs using my fork of the dev branch which what I'm currently doing at the moment?

Please let me know when you have a chance.

Hope all is well across the pond!

Cheers, Davey

roofdog commented 4 years ago

Hi Davey,

I'm closing this PR as I got all the changes you suggested into the last release (2.2.1). Hopefully I didn't miss anything out as this PR was confusing!

TBH I don't know the best way to do this going forward - I can't really get my head around github as I just don't use it enough for it to become familiar with. I'm trying to use it more and keep more up-to-date with commits so I'm sure we will work out the best workflow eventually.

Thanks for all your efforts, it is massively appreciated :)