search

WPI-AIM / ambf

Asynchronous Multi-Body Framework
163 stars 67 forks source link

Fix checking Package_FOUND variables #189

Closed kschwan closed 1 year ago

kschwan commented 2 years ago

Hi, I tried building AMBF on Ubuntu 22.04 (without ROS/catkin) and got an error when checking the value of catkin_FOUND. If packages are not found, Package_FOUND variables do not exist and trying to check their value will cause cmake to return an error. This PR has a small patch to check the existence of the Package_FOUND variables and not their value.

adnanmunawar commented 2 years ago

Thanks for the PR Kim. Happy to hear that you made it to work with Ubuntu 22.04. I shall test these modifications on Ubuntu 20.04 to verify that they also work there and then integrate the PR.

Out of curiosity, as far as I know, one has to build ROS1 from source on Ubuntu 22.04, is that what you did?

kschwan commented 2 years ago

Sorry I kinda forgot replying here. I didn't build ROS1 from source, I just built AMBF without ROS support (I suppose?).

kschwan commented 1 year ago

Thanks for the PR Kim. Happy to hear that you made it to work with Ubuntu 22.04. I shall test these modifications on Ubuntu 20.04 to verify that they also work there and then integrate the PR.

Out of curiosity, as far as I know, one has to build ROS1 from source on Ubuntu 22.04, is that what you did?

Just to satisfy your curiosity: I now did compile ROS Noetic on Ubuntu 22.04 and it seems to work fine with AMBF also except for some compile issues. I needed to use C++17 because of some rosconsole/log4cxx changes, but AMBF CMake configs explicitly sets C++11 flags in a number of places, overriding any previously set CMAKE_CXX_STANDARD or sometimes passing -std=c++0xor -std=c++11 directly).

adnanmunawar commented 1 year ago

Thanks for checking this, Kim. I also tested the PR on Ubuntu 20.04 and it works. We can probably address the issue of C++17 compilation in a new PR.