search

WPIRoboticsEngineering / RBE1001Lib

A library to support introduction to robotics engineering.
MIT License
4 stars 4 forks source link

lowercase methods #34

Closed gcl8a closed 4 years ago

gcl8a commented 4 years ago

When motor.cpp/h are stable (ie, I don't want to create merge conflicts), I will go in and change my functions to classis camelCase. My habit of Capitalizing functions is too confusing. Just let me know a good time to do it.

madhephaestus commented 4 years ago

Ill assign this issue to you, you change it and put this issue number in the commit and close. I will not touch Motor until this is closed.

madhephaestus commented 4 years ago

Alternatively you can assign it to me and ill go and poke the method names

gcl8a commented 4 years ago

I’m doing it now. Almost done.

On Aug 27, 2020, at 11:32 AM, Kevin Harrington notifications@github.com wrote:

Alternatively you can assign it to me and ill go and poke the method names

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/WPIRoboticsEngineering/RBE1001Lib/issues/34#issuecomment-682023455, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF5JK5DGHTS4LGYDHXTPLV3SCZ37BANCNFSM4QM5Y7HQ.

gcl8a commented 4 years ago

It's done. I tested all of the examples, but it's possible I missed something. Let me know if you encounter any problems.

I think you deleted FullSystemTest -- I had a merge conflict. I put it back in, only because I don't want to clobber our example until you're ready. We should save the FullSystemTest for our use (in a private repo?).

madhephaestus commented 4 years ago

with the updated API. lets tag a version, then delete it. The code is there for our use for reference, but will be gone out of the students examples.

madhephaestus commented 4 years ago

its will always be here: https://github.com/WPIRoboticsEngineering/RBE1001Lib/blob/0.7.1/examples/FullSystemTest/FullSystemTest.ino

gcl8a commented 4 years ago

Got it. I know it’s all in the history — I’m just not always confident about how to go back in time.

And please excuse if I missed any function names. Everything seemed to compile, but you never know. Better to clean it all up now, obviously, than during the term.

On Aug 27, 2020, at 11:48 AM, Kevin Harrington notifications@github.com wrote:

its will always be here: https://github.com/WPIRoboticsEngineering/RBE1001Lib/blob/0.7.1/examples/FullSystemTest/FullSystemTest.ino https://github.com/WPIRoboticsEngineering/RBE1001Lib/blob/0.7.1/examples/FullSystemTest/FullSystemTest.ino — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/WPIRoboticsEngineering/RBE1001Lib/issues/34#issuecomment-682032968, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF5JK5DKDYSZK6A2ATNW63DSCZ553ANCNFSM4QM5Y7HQ.