WPIRoboticsProjects / GRIP

Program for rapidly developing computer vision applications
http://wpiroboticsprojects.github.io/GRIP
Other
374 stars 108 forks source link

Use WPILib Version Plugin for ntcore #730

Open AustinShalit opened 7 years ago

AustinShalit commented 7 years ago

https://github.com/wpilibsuite/wpilib-version-plugin

JLLeitschuh commented 7 years ago

I don't know if I like this. If WPILib pushes out a breaking change does it break our CI system unexpectedly?? @333fred Please advise

333fred commented 7 years ago

So, what type of breaking change could we possibly make here? You're depending on a specific version of the plugin, it's not like we're going to go back and republish a specific version.

That being said, I don't know if you need to use it. It could certainly help you automate what repo you're using to get ntcore from, but for your use case it doesn't have much use beyond that.