WPIRoboticsProjects / GRIP

Program for rapidly developing computer vision applications

http://wpiroboticsprojects.github.io/GRIP

Other

379 stars 107 forks source link

Fix UI tests on Azure #946

Closed SamCarlberg closed 5 years ago

SamCarlberg commented 5 years ago

Switch to Linux for running the UI tests Install OpenJFX and openjdk through apt

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5a8e1b4). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #946   +/-   ##
=========================================
  Coverage          ?   52.89%           
  Complexity        ?        1           
=========================================
  Files             ?      329           
  Lines             ?     8892           
  Branches          ?      561           
=========================================
  Hits              ?     4703           
  Misses            ?     3985           
  Partials          ?      204

SamCarlberg commented 5 years ago

@JLLeitschuh Thoughts on why the code coverage dropped so much?

JLLeitschuh commented 5 years ago

No idea. This doesn't seem like the kind of thing that would cause it. Perhaps there is binary jacoco comparison going on?

SamCarlberg commented 5 years ago

I think it might be because there was no coverage report for the latest commit on master. I'm not sure, though

SamCarlberg commented 5 years ago

Oh, the UI tests aren't running because Java 11 is being used instead of Java 8 :man_facepalming:

SamCarlberg commented 5 years ago

ZuluFX is an OpenJDK + OpenJFX build provided by Azul Systems (https://www.azul.com/). We used the embedded Zulu JRE on the RoboRIO for the 2018 FRC season