WPManageNinja / fluent-smtp

FluentSMTP - WordPress SMTP & Email Service API connection Plugin
https://fluentsmtp.com
86 stars 44 forks source link

Plugin 101, Scope your composer dependencies. #99

Open calvinalkan opened 2 years ago

calvinalkan commented 2 years ago

Fluent-SMTP contains a verbatim copy of monolog, guzzle, and several PSR interfaces.

The way autoloading works in PHP you will give some people a very bad time with this setup if your included dependency gets loaded before any composer dependencies a user might define in his site.

This is really plugin 101. If you use composer dependencies you MUST scope them in a build step.

jordantrizz commented 1 year ago

Any idea when this will be addressed?