WPP-Public / akqa-nz-silverstripe-responsive-images

Provides support for configurable sets of responsive images using Javascript
GNU General Public License v2.0
54 stars 26 forks source link

ENH: add include_picturefilljs config setting #12

Closed christopherdarling closed 8 years ago

christopherdarling commented 8 years ago

Allows for easy removal of picturefill JS script via config setting

stecman commented 8 years ago

Can you explain your use-case for this?

silverstripesk commented 8 years ago

Hmm, he has probably this script already included (and combined)? Still, its easy to block any JS file: Requirements::block(RESPONSIVE_IMAGES_DIR.'/javascript/picturefill/picturefill.min.js');

christopherdarling commented 8 years ago

@silverstripesk is correct in the reason behind this. I guess there's no real benefit in config over Requirements::block(). Closing...