search

WPP-Public / akqa-nz-silverstripe-responsive-images

Provides support for configurable sets of responsive images using Javascript
GNU General Public License v2.0
54 stars 26 forks source link

allow SS5 #37

Closed xini closed 1 year ago

madmatt commented 1 year ago

Looks great, thank you!

xini commented 1 year ago

Thank you! Can you please tag this?

madmatt commented 1 year ago

Done: https://github.com/heyday/silverstripe-responsive-images/releases/tag/3.0.0

xini commented 1 year ago

Thanks!

xini commented 1 year ago

I would have done 2.1.0 though?

madmatt commented 1 year ago

While no functionality has really changed warranting a new major version number, it does provide a clear point in time - version 2 supports CMS 4, version 3 only needs to support CMS 5 going forward (so in future we may remove support for CMS 4, if the feature we want to use is only in CMS 5). It's unlikely this will happen, but I think updating our major version number to match the increase in the CMS major version number makes at least some kind of sense :)

xini commented 1 year ago

No worries. My thinking is that when you drop support for 4 you'll have to do a new major anyway. So right now, it's just adding compatibility, but then it breaks on the current major.