WPP-Public / akqa-nz-silverstripe-responsive-images

Provides support for configurable sets of responsive images using Javascript
GNU General Public License v2.0
54 stars 26 forks source link

Does this work in SS 3.1.6? #5

Closed hp7 closed 10 years ago

hp7 commented 10 years ago

I install add to config but nothing happens. No error or anything in the output suggesting it is doing anything. No visible change in output code. Not sure if I am missing something. Do I need to add anything to template code?

stecman commented 10 years ago

Do I need to add anything to template code?

Hi @hp7, as outlined in the readme you'll need to configure your settings for the module in YAML, then reference that configuration in a template by name:

Template:

$Image.ResponsiveSet1

Config:

ResponsiveImageExtension:
  sets:
    ResponsiveSet1:
      sizes:
        - {query: "(min-width: 200px)", size: 100}
        - {query: "(min-width: 800px)", size: 400}
        - {query: "(min-width: 1200px)", size: 800}

This is the result I get (gif) in SilverStripe 3.1.6 copying the usage examples in the readme. Make sure you've done a flush to pick up the config changes too.

stecman commented 10 years ago

I've updated the readme in bb4d9df to make the required configuration clearer. I'll close this issue for now as the module is confirmed to work with SilverStripe 3.1.6.

hp7 commented 10 years ago

Thx

Sent from my iPhone

On Nov 4, 2014, at 3:58 PM, Stephen Holdaway notifications@github.com wrote:

I've updated the readme in bb4d9df to make the required configuration clearer. I'll close this issue for now as the module is confirmed to work with SilverStripe 3.1.6.

— Reply to this email directly or view it on GitHub.