Initial 2.0 Version - Use recent picturefill2 polyfill

WPP-Public / akqa-nz-silverstripe-responsive-images

Provides support for configurable sets of responsive images using Javascript

GNU General Public License v2.0

54 stars 26 forks source link

Initial 2.0 Version - Use recent picturefill2 polyfill #6

Closed Xarinor closed 9 years ago

Xarinor commented 9 years ago

I wrapped up a initial picturefill 2.x version of silverstripe-responsive-images. Please review my changes and decide on how you could make use of them (branch/tag/master)

stecman commented 9 years ago

Thanks, @Xarinor. This looks like it might work as a minor release, since the API is the same as the current release (the fact the output is changing doesn't matter if it behaves the same as before). Can you please squash your commits?

Xarinor commented 9 years ago

Thanks for the fast review @stecman. I rebased the commits.

I was thinking on removing the picturefill from the repository and adding it as a dependency, you might want to try that so we can slim it out?
Also i am interested in adding a more complete / optimized template even though all users may want to add their own markup anyways.. I consider using the module in a small framework, thanks for your work so far!

stecman commented 9 years ago

Cheers @Xarinor. I've had a play with this and it's all good, thanks. Not sure how we'll release this yet, since the size definitions in the config needs to be reversed for it to work, but it's in master now anyway.

:+1: