Describe the bug
When I first used the modeller, I was dissappointed, that there is no save shortcut, because intuitively I used cmd + s. This is the default shortcut for most editing tools and I did not bother to look in the manual or the handy popup at the top. Only later did I discover, that I had to press ctrl instead of cmd for shortcuts. I would expect, that egon.io is aware of the platform the users browser runs on and handles the shortcuts according to the expectation of the user.
To Reproduce
Use egon.io on a MacOS and press cmd + s or any other shortcut that uses a modifier
Expected behavior
All the shortcuts that have ctrl today should trigger with cmd instead if the user works on a MacOS system. The description should also state this.
Version
Egon: v2.1.0
Browser: chrome 128
OS: MacOS
Solution options
One way to find out which operating system the user is on, is to use the angular-device-information package. An easier way to handle this is to just listen to both modifiers, with the side effect, that on a MacOS System, ctrl or cmd will both work. I don't think, that this will really create a usability problem though, as MacOS users don't usually use the ctrl modifier anyways. This has the added benefit of not being a breaking change, so we could keep the old behaviour and additionally fix this for new users.
The shortcuts that are handed by the modeller itself already listen to both modifiers, so I would suggest that we go this way for consistency.
Let me know if you would be willing to accept a PR, and which solution you prefer.
Describe the bug When I first used the modeller, I was dissappointed, that there is no save shortcut, because intuitively I used
cmd + s. This is the default shortcut for most editing tools and I did not bother to look in the manual or the handy popup at the top. Only later did I discover, that I had to pressctrlinstead ofcmdfor shortcuts. I would expect, that egon.io is aware of the platform the users browser runs on and handles the shortcuts according to the expectation of the user.To Reproduce Use egon.io on a MacOS and press
cmd + sor any other shortcut that uses a modifierExpected behavior All the shortcuts that have
ctrltoday should trigger withcmdinstead if the user works on a MacOS system. The description should also state this.Version
Solution options One way to find out which operating system the user is on, is to use the angular-device-information package. An easier way to handle this is to just listen to both modifiers, with the side effect, that on a MacOS System,
ctrlorcmdwill both work. I don't think, that this will really create a usability problem though, as MacOS users don't usually use thectrlmodifier anyways. This has the added benefit of not being a breaking change, so we could keep the old behaviour and additionally fix this for new users.The shortcuts that are handed by the modeller itself already listen to both modifiers, so I would suggest that we go this way for consistency.
Let me know if you would be willing to accept a PR, and which solution you prefer.