Open jrfnl opened 6 years ago
FYI: The detaching of this repo from the WPCS repo in git terms is happening soon.
There are/were 18 forks of the WPCS repo which were based off the TRTCS fork. Those forks will remain attached to this repository and will not revert to being forks of WPCS upstream.
Once the detaching is done, the repo name will be updated as well to make it abundantly clear that this repo is a stand-alone project from that point on-wards.
WPThemeReview
./cc @carolinan @djrmom @dmtrmrv @ernilambar @Roshanb54 @fervillz @fklein-lu @khacoder @kkoppenhaver @krishna19 @miya0001 @nasabikram @Pross @purevtsooj @RCSWebDev @rinkuyadav999 @sachyya @selul
Create a PR for the decoupling against develop.
For the decoupling, there are two possible ways to go:
master
and develop
branches and creating new virgin orphan branches with those same names. Creating an orphan feature branch, cherrypicking all the commits done for this project + the files from WPCS which we want to keep and adjust. And then pulling the branch with all the cherrypicks to the empty develop
branch.
This would clear out all the old WPCS history - except for the history of the files we are keeping (should be only +/- 8 files) - and give us a clean history with only the commits relevant to this repository and credit to the people who have contributed to the files which will stay in the repository.
The downside of this is, that it may be confusing for existing contributors that the repo will have changed completely.The effect of either option on existing pull request is about the same. In both cases, the pull requests will need to be rebased against the new develop
anyway and the sniff categories changed, As the open PRs are all either new sniffs - and therefore new files - or changes against files which were new to this repo anyway, the rebase should be relatively painless either way.
@pattonwebz @dingo-d @grappler What do you think ? Have you got a preference ?
Option 1 is the simplest to execute, option 2 would give us a far cleaner base to continue from.
As discussed on slack, I'm for option 2
The branch which is intended to be the new repo content & history, is now online for review: https://github.com/WPTRT/WPThemeReview/tree/feature/163-166-167-169-decouple-from-WPCS
This has been done, so ti can be closed, no?
I think we left it open at the time as the open PRs which got automatically closed haven't been updated and re-pulled yet. Still somewhere on my never-ending to-do list.....
Follow-on issue for #163.
Action list:
PRfeature branch for the decoupling againstdevelop
.composer.json
file..gitignore
,phpunit.xml.dist
etcWordPress
subdirectory toWPThemeReview
and update the ruleset documentation (name + description) to match.use
statements to sniffs and where relevant adjust sniff code.@since
tags and sniff changelogs in the docblocks of all sniffs which will remain in WPTRTCS.PHPCSHelper
class.Once the PR is merged, open a PR to merge. Once the feature branch has been approved, remove the existingdevelop
intomaster
and tag release0.1.0
develop
andmaster
branches, rename the feature branch todevelop
, create a newmaster
pointing to the same commit and tag release0.1.0
.develop
and remove thetheme-review-sniffs
branch.develop
and add a comment in the PR that the PR needs to be rebased and adjusted for the new categories.[EDIT]