Warn on empty statements

WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions

MIT License

208 stars 38 forks source link

Closed jrfnl closed 5 years ago

jrfnl commented 5 years ago

Related to PR #152 which added the wrong sniff ... oops.

The Generic.CodeAnalsysis.EmptyStatement (added in #152) checks for empty control structure leafs, i.e.
```
if ($a = $b) {
    // This would be reported.
} else {
    $b = $a;
}
```
Generic.CodeAnalysis.EmptyPHPStatement (open PR upstream squizlabs/PHP_CodeSniffer#1814) /WordPress.CodeAnalysis.EmptyStatement checks for empty PHP tags <?php ?> and double semi-colons, like statement; ;.

With this PR, the missing check is added.

jrfnl commented 5 years ago

@dingo-d If you're happy with it, you're welcome to merge it ;-)

dingo-d commented 5 years ago

I'm used to letting the person who opened the PR to merge it after approval 🙂

But good to know for the future reference 😄

jrfnl commented 5 years ago

I'm used to letting the person who opened the PR to merge it after approval

grin I'm used to never merge my own PRs, always considered that a bit of a no-no.