WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions
MIT License
208 stars 38 forks source link

Build/Travis: test builds against PHP 7.3 #183

Closed jrfnl closed 5 years ago

jrfnl commented 5 years ago

Once PHP 7.3-beta came out, the nightly build on Travis became PHP 7.4-dev and build haven't been tested against PHP 7.3 for months now.

Luckily, Travis has finally deemed it appropriate to set up a PHP 7.3 alias now RC3 is out, so I've now removed it from the "allowed to fail" list, at least for the higher PHPCS version.

PHP 7.3 in combination with PHPCS 3.x, but lower than 3.3.1 should be allowed to fail as PHPCS wasn't fully compatible with PHP 7.3 until version 3.3.1.

dingo-d commented 5 years ago

Any ideas why it's failing on PHP 5.4?

[Composer\Downloader\TransportException]  
  Peer fingerprint did not match            
jrfnl commented 5 years ago

@dingo-d Looks like that was just a Travis-Packagist hickup. I've restarted the relevant builds, they should be passing.