search

WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions
MIT License
208 stars 38 forks source link

Referenced sniff "WordPress.CodeAnalysis.EmptyPHPStatement" does not exist #185

Closed ntwb closed 5 years ago

ntwb commented 5 years ago

Once up and running ./vendor/bin/phpcs -p . --standard=WPThemeReview results in:

ERROR: Referenced sniff "WordPress.CodeAnalysis.EmptyPHPStatement" does not exist

Removing the following works around the issue:

https://github.com/WPTRT/WPThemeReview/blob/50ba5f783d4848342fc82760fa2211a0a9697eff/WPThemeReview/ruleset.xml#L51-L52

My composer.json contents:

    "require-dev": {
        "dealerdirect/phpcodesniffer-composer-installer": "~0.4.4",
        "wp-coding-standards/wpcs": "~1.1.0",
        "wptrt/wpthemereview": "dev-develop"
    },
jrfnl commented 5 years ago

You're right, PR upcoming.

dingo-d commented 5 years ago

The PR has been merged, @ntwb can you please test it now, just to be on the safe side? 🙂