search

WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions
MIT License
208 stars 38 forks source link

🍾 Next release planning [0.2.0] #189

Closed dingo-d closed 5 years ago

dingo-d commented 5 years ago

Now that the 0.1.0 is out 🎉 I think that we should try to keep the momentum and make some kind of planning as to what can be done for the next release 🙂

We can have a hangouts meeting, but we can also leave comments here about it.

I was thinking that we should go through the issues, see what can be closed, and maybe see which sniff proposals would be good to tackle (maybe some easy ones).

Even setting up a release timeline wouldn't be a bad idea, maybe set a milestone (or even several of them) and go through the issues and tag them according to each milestone. This will give us some sense of completion for each release.

I'd also like for theme review admins to join so that we can update the theme review handbook, to closely follow the standards (for less confusion), but also because it could do with some updates in the general sense 🙂

And last but not the least, we need to find a way to reach out to find more contributors. This part is the trickiest, but people need to know that contributing is not only writing sniffs but also writing good/bad code examples.

I'd like to hear your thoughts about this.

@jrfnl @grappler @ernilambar @jocastaneda @carolinan @justintadlock @pattonwebz

joyously commented 5 years ago

Does that include making it so anyone can run it? My eyes glaze over if I have to install 3 tools to use this tool.

dingo-d commented 5 years ago

It's actually super easy to run it in a project, you can check the twentynineteen and wprig PR, it's a matter of adding it to composer and running the composer script. Couldn't be easier 😄

joyously commented 5 years ago

Couldn't be easier

Well, yes it's easier if I don't have to figure out Composer and its script. I like the WP plugin route.

dingo-d commented 5 years ago

Well, yes it's easier if I don't have to figure out Composer and its script. I like the WP plugin route.

This is where theme-sniffer comes into play, but that's not related to this repo 😉

jocastaneda commented 5 years ago

Just now seeing this. Will take a look over in the next couple of days

dingo-d commented 5 years ago

Just a self reminder: Downgrade the prefix sniff to a warning instead of error in the next release, and possibly release the 0.2.0 (or 0.1.1) this week so that it can be used in the next release of the Theme Sniffer plugin

jrfnl commented 5 years ago

Downgrade the prefix sniff to a warning instead of error in the next release,

I would strongly recommend against that. If anything, you may just want to downgrade the specific message about non-prefixed variables which is causing all the strive, definitely not the whole sniff.

possibly release the 0.2.0 (or 0.1.1) this week so that it can be used in the next release of the Theme Sniffer plugin

I'd suggest holding off for a week or so, WPCS 2.1.0 is expected to be released soon and it might be a good idea to update before releasing a new Theme Sniffer version.

dingo-d commented 5 years ago

The progress of the 0.2.0 release is as follows:

Added

Changed

Removed

To do (PRs pending review):

I'll collect all the tickets for decision needed and propose that we go through them in a meeting to resolve them.

Issues that need discussion in the meeting before decision is made

jrfnl commented 5 years ago

One more TODO: I expect WPCS 2.1.1 to be released this week, so TRTCS may as well upgrade to using that (should be automatic as there is no composer.lock, but being explicit doesn't hurt).

dingo-d commented 5 years ago

All the changes will be in the changelog once the release is out, I'll close this issue and when the release is out and I sit down a bit I will open a new roadmap for the next release.