search

WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions
MIT License
208 stars 38 forks source link

fixing headers already sent message #204

Closed timelsass closed 5 years ago

timelsass commented 5 years ago

Messages in Squiz.WhiteSpace.SuperfluousWhitespace.StartFile, and PSR2.Files.ClosingTag.NotAllowed reference "headers already send", but should be "headers already sent". Added a missing comma for PSR2.Files.ClosingTag.NotAllowed message as well.

justintadlock commented 5 years ago

Just making a note that this is another one of those things that doesn't need to apply to templates (headers have already been sent by the time the templates are output).

jrfnl commented 5 years ago

@timelsass Thank you for the PR!

@justintadlock Could you open a separate issue for that ? Unless and until there is a list of template files we can check filenames against to see if a rule should be applied, this shouldn't be changed as themes normally will also load other files and it does apply to those.

justintadlock commented 5 years ago

Definitely. I just wanted to make a note so that it'd be on the record.