prevent phpcs PHP internal msg on css/js sniffs

WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions

MIT License

208 stars 38 forks source link

prevent phpcs PHP internal msg on css/js sniffs #207

Closed timelsass closed 5 years ago

timelsass commented 5 years ago

Initially reported by @Mocha365 in issue https://github.com/WPTRT/theme-sniffer/issues/140. It looks like the internal message from phpcs gets thrown on css/js file sniffs. Initially I thought it might have been because the runner isn't actually setting the extensions, but even after doing that it wasn't suppressed. This pull will just restrict it to only the php/inc extensions.

timelsass commented 5 years ago

I think you are right, I just ran some tests with a mostly unmodified phpcs core runner class and it seems to actually detect the minfied files. It was also not running out of memory in a large repo, which in the current version of theme sniffer, it normally does. I'll reopen if there's something, but I'll look into the extensions handling vs what phpcs is doing. Thanks for taking a look 😀!