Include post per page rule and make it into a warning

WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions

MIT License

207 stars 38 forks source link

Include post per page rule and make it into a warning #218

Closed dingo-d closed 5 years ago

dingo-d commented 5 years ago

As noted in the issue #147 there was an agreement in the meeting to use the posts per page sniff, but that the ruleset should throw a warning instead of an error.

dingo-d commented 5 years ago

Note to self: This PR needs to be updated:

Extend the WordPress.WP.PostsPerPage sniff and add a warning if users use -1 as a value in posts_per_page argument

dingo-d commented 5 years ago

@jrfnl I've extended the PPP sniff from WPCS and added a notice for disabling pagination (setting posts_per_page to -1).

EDIT: Sorry for pinging you @jrfnl but any chance this could get sorted before WCEU? 🙂