search

WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions
MIT License
207 stars 38 forks source link

Travis: ignore PHP deprecation notices for stable PHPCS releases #230

Closed jrfnl closed 5 years ago

jrfnl commented 5 years ago

The unit tests will fail when a PHP warning/notice/deprecation notice is encountered.

Deprecation notices thrown by already released PHPCS versions won't get fixed anymore (in that version), so failing the unit tests on those is moot and will skew the reliability of the Travis results.

To see the effect you'd need to check the Travis logs for the PHP 7.4 builds and compare them with a recent build on another branch, like https://travis-ci.org/WPTRT/WPThemeReview/builds/561796063 .

jrfnl commented 5 years ago

Oh and I forgot to mention:

The PR also makes it so this repo gets unit tested against WPCS develop as the "high" version, not master which is the latest release.

Testing against the latest release means we don't get early warning about upstream changes we need to account for in the sniffs in this repo, while we should.

Note: I've not changed the WPCS branch being used for the CS check of the code in this repo. It makes more sense for the CS changes to be done on stable WPCS releases and not every time something changes upstream.