WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions
MIT License
209 stars 37 forks source link

PrefixAllGlobals sniff - add the version number in the docblock #234

Closed dingo-d closed 5 years ago

dingo-d commented 5 years ago

Since WPCS 2.2.0 was released, I'm getting errors when working with theme sniffer (I updated the packages), so I thought we'd release this as a part of the 0.2.1. hotfix release (I'll try to sort the rest of the issues in some reasonable milestones so that we get this thing going).

jrfnl commented 5 years ago

@dingo-d I've taken the liberty to rebase this PR which should allow the build to pass and make this PR mergable.

The other PRs also need rebasing, but I'll leave that up to you as they also still need other changes.

dingo-d commented 5 years ago

Yeah, I started working on the package version, will rebase all of them once done (probably in a few hours because I need to go to family lunch). Thanks for helping out 🙂

jrfnl commented 5 years ago

@dingo-d Enjoy lunch & bring some back for me, will you ?