WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions
MIT License
209 stars 37 forks source link

Travis: fix the build #251

Closed jrfnl closed 4 years ago

jrfnl commented 4 years ago

The Travis docs say that $TRAVIS_BUILD_STAGE_NAME is in "proper case" form:

TRAVIS_BUILD_STAGE_NAME: The build stage in capitalized form, e.g. Test or Deploy. If a build does not use build stages, this variable is empty ("").

However, it looks like they made an (undocumented) change (probably a bug in their script handling) which means that the $TRAVIS_BUILD_STAGE_NAME name is now in the case as given, which in this case is lowercase.

This means that some of the comparisons are failing and the wrong things are executed for certain builds.

As I expect this to be a bug in Travis, I'm not changing the case for the comparisons at this time. Instead I'm fixing this by inline fixing the case of the variable for the comparisons.

Refs:

jrfnl commented 4 years ago

Darn, sorry, didn't mean to close this.

I just noticed the build wasn't reporting back. I've restarted the build now, :crossed_fingers: that it will report back correctly now.

jrfnl commented 4 years ago

Grr.. build passes (again), but still not reporting back. Going to try a force push now.

jrfnl commented 4 years ago

@dingo-d Something seems to be wrong with the Travis reporting back. Shall I close this PR and open a new one for the same to see if that fixes it ?

dingo-d commented 4 years ago

Sure open a new one 👍 Thanks!