search

WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions
MIT License
207 stars 38 forks source link

Travis: fix the build #252

Closed jrfnl closed 4 years ago

jrfnl commented 4 years ago

Same as #251 in the hopes that the build will report back now.

The Travis docs say that $TRAVIS_BUILD_STAGE_NAME is in "proper case" form:

TRAVIS_BUILD_STAGE_NAME: The build stage in capitalized form, e.g. Test or Deploy. If a build does not use build stages, this variable is empty ("").

However, it looks like they made an (undocumented) change (probably a bug in their script handling) which means that the $TRAVIS_BUILD_STAGE_NAME name is now in the case as given, which in this case is lowercase.

This means that some of the comparisons are failing and the wrong things are executed for certain builds.

As I expect this to be a bug in Travis, I'm not changing the case for the comparisons at this time. Instead I'm fixing this by inline fixing the case of the variable for the comparisons.

Refs:

jrfnl commented 4 years ago

@dingo-d I have a feeling that the connection with Travis is broken and needs to be redone.

I had a quick look to see what's different compared to some other repos and I think removing the webhook might just fix this as there is already a GH App integration in place. What do you think ?

dingo-d commented 4 years ago

I know that GitHub removed services in favor of webhooks, but since we have Travis app connected to this repo we could try removing the webhook.

jrfnl commented 4 years ago

@dingo-d I've removed the webhook and restarted the build. Hoping it will report back now. Otherwise, I'll try a force push again.

jrfnl commented 4 years ago

@dingo-d Still no luck. I'll close this PR and re-open a new one as a last attempt. If that doesn't work, someone who can edit the GH Travis App permissions should probably have a look and/or remove and re-add the GH App.