search

WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions
MIT License
207 stars 38 forks source link

Allow admin pages #255

Open aristath opened 4 years ago

aristath commented 4 years ago

Possible fix for #254

dingo-d commented 4 years ago

I kinda think that Travis is failing due to all the changes on develop branch of WPCS 😬

pattonwebz commented 4 years ago

We probably want to pin a specific version of phpcs then.

dingo-d commented 4 years ago

It's not because of PHPCS, it's because of WPCS. There is an effort to rewrite tons of it using new awesome utils written by @jrfnl. Not 100% sure why it fails, will probably have to look at it in depth when I have the time.

jrfnl commented 4 years ago

@dingo-d I already checked, some of the utilities from WPCS which have been removed are used in sniffs here, that's why. Also with PHPCSUtils in alpha, minimum stability is an issue.

As for updating the Travis script - either fix it to WPCS dev-master instead of dev-develop as "high" version, or considering that there's not that much activity in this repo, leave it for the time being and fix it by upgrading to WPCS 3.0/PHPCSUtils for the next version.

I started updating the Travis script last week and then didn't pull it with the above in mind, but if you like I can pull it anyway.

dingo-d commented 4 years ago

I mean if it solves the current problem then you can update Travis script. But this is actually an excellent opportunity to start using utils here 🙂

jrfnl commented 4 years ago

I mean if it solves the current problem then you can update Travis script. But this is actually an excellent opportunity to start using utils here

@dingo-d Those two things are unrelated.

We can start using PHPCSUtils already, but that wouldn't automatically solve the build failure for WPCS dev-develop as sniffs have been removed etc

So, upgrading to WPCS 3.0.0 and starting to use PHPCSUtils are two different "projects", though they can be done at the same time, in which case it will be easiest to do so once WPCS 3.0.0 is in RC and it is clear what has changed.

Considering there is still plenty to be done for WPCS and PHPCompatibility at the moment, I'm not keen to take on a third such project concurrently, but feel free to get started yourself ;-)

dingo-d commented 4 years ago

Oh I was thinking of doing this myself (a separate task ofc) ^^

dingo-d commented 3 years ago

@aristath We have moved away from Travis to GH actions for CI checks. Can you rebase your PR so that we may see if the checks will pass?

aristath commented 3 years ago

Done :+1:

dingo-d commented 3 years ago

All the tests are passing so I think it's ok to merge.