search

WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions
MIT License
207 stars 38 forks source link

Improve plugin-territory list of block-related functions #257

Closed aristath closed 3 years ago

aristath commented 3 years ago

The current rule disallows adding patterns, styles, scripts etc.

This change tweaks the list of plugin-territory functions to the ones that should actually only be in plugins

dingo-d commented 3 years ago

Some dependencies are not right. I can check that later. @jrfnl Do you maybe know what's this about?

jrfnl commented 3 years ago

Some dependencies are not right. I can check that later. @jrfnl Do you maybe know what's this about?

Yes, there are a couple of things going on:

  1. TRTCS uses WPCS dev-develop in Travis, which is now 3.0-dev.
  2. Until PHPCSUtils 1.0 is released, the PHPCSUtils dependency is regarded as dev and the TRTCS Composer config does not allow for dev dependencies (minimum_stability)
  3. Aside from that, the code in TRTCS expects WPCS 2.x, not 3.x.

I suggest switching to WPCS dev-master for Travis for the time being and adding a single "allowed to fail" build against WPCS dev-develop.

dingo-d commented 3 years ago

@aristath Can you rebase this PR as well so that we can check the GH Actions checks?

aristath commented 3 years ago

Done