search

WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions
MIT License
207 stars 38 forks source link

GH Actions: turn display_errors on #265

Closed jrfnl closed 3 years ago

jrfnl commented 3 years ago

Turns out the default setting for error_reporting used by the SetupPHP action is error_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICT and display_errors is set to Off.

For the purposes of CI, I'd recommend running with E_ALL and display_errors=On to ensure all PHP notices are shown.

In the test script, error_reporting was already enabled, but the error display was not yet fixed. Sorted now. In the lint script, both were missing.

jrfnl commented 3 years ago

Note: the current build failure against PHP 8.1 was expected - this is an upstream issue with the PHP Parallel Lint package and I've already pulled a fix there: https://github.com/php-parallel-lint/PHP-Parallel-Lint/pull/64