search

WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions
MIT License
209 stars 37 forks source link

No PHP File Functions #79

Closed khacoder closed 6 years ago

khacoder commented 8 years ago

Issue #71

grappler commented 8 years ago

Looks good, just needs to pass the check. I need to test it too.

jrfnl commented 8 years ago

This looks like duplicate code with upstream. Please check if the upstream code can be/needs to be improved and do so and just refer the upstream sniff in the ruleset.

This should not be a theme specific sniff.

grappler commented 8 years ago

I will look that all of the functions are fully integrated in https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/633

Leaving this open for the moment till the PR is merged upstream.

jrfnl commented 6 years ago

Closing this PR.

A new PR will be opened to add the complete WP.AlternativeFunctions sniff to TRTCS. This will basically be a sniff extending the upstream one and overruling the getGroups() method to change the error type for all but two groups.