search

WPTT / WPThemeReview

PHP_CodeSniffer rules (sniffs) to enforce WordPress theme review coding conventions
MIT License
209 stars 37 forks source link

Change error silencing rule from warning to error. #99

Closed jrfnl closed 7 years ago

jrfnl commented 7 years ago

See https://github.com/WPTRT/WordPress-Coding-Standards/issues/83#issuecomment-268009879

@ernilambar Care to test with this branch ?

FYI: in this case the specific sniff referenced has a public property which determines whether the sniff should throw a warning or an error. The property defaults to false (=warning), so changing the property to true fixes this. This also changes the error code the sniff uses which is why - in this case - this is the more appropriate way to change the error type.

grappler commented 7 years ago

Tested it and it works as expected.

emiluzelac commented 7 years ago

Thanks @grappler

On Mon, Dec 19, 2016 at 2:26 PM Ulrich Pogson notifications@github.com wrote:

Merged #99 https://github.com/WPTRT/WordPress-Coding-Standards/pull/99.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WPTRT/WordPress-Coding-Standards/pull/99#event-899184596, or mute the thread https://github.com/notifications/unsubscribe-auth/ABs6zgBcPaWK82uqZDBrVDF-8fxVLTxgks5rJuiBgaJpZM4LRIdE .