search

WPTT / theme-sniffer

Theme Sniffer plugin using sniffs.
MIT License
270 stars 3 forks source link

fixes #102 #106

Closed timelsass closed 5 years ago

timelsass commented 5 years ago

@dingo-d it looks like the testVersion config set in the wptrt ruleset.xml is overriding the cli --runtime-set for testVersion. Removing the testVersion from the xml showed this to be true.

Upon looking into the runner, it looks like it needs to be initialized first, and then set the set_config_data calls will work as expected.

dingo-d commented 5 years ago

Thanks for the PR! I really appreciate it 🙂

It's weird that the testVersion set in the ruleset meant for the plugin itself is picked up by the runner, as it should pick up the standard set in the config.

Anyhow, once you fix the minor thing I mentioned (just returning the array) the PR is good to merge 👍

If you find any more issues or possible code optimisations feel free to send in a PR 🙂

dingo-d commented 5 years ago

Thank you for the contribution! I really appreciate it. If you see some more things in the code that can be improved or fixed just send a PR 🙂