search

WPTT / theme-sniffer

Theme Sniffer plugin using sniffs.
MIT License
270 stars 3 forks source link

woocommerce sniffs #116

Closed timelsass closed 5 years ago

timelsass commented 5 years ago

Feature Request:

WooCommerce is fairly common in themes - It would be nice to add additional checks for template override versions matching the latest release version of wooCommerce. This would alert authors that they need to update their templates to the latest version.

This check could be initiated if add_theme_support for woocommerce was found in php files.

dingo-d commented 5 years ago

What would we be checking for? Could that be handled by the phpcs? If so I think that WPThemeReview would be a better fit for this issue.

timelsass commented 5 years ago

Perhaps - I wasn't sure which would be the best place - I would think searching an array of template override files that themes usually provide in a theme in a /woocommerce folder. There is a version included in the php comment of the file header, and that's compared internally in woocommerce with their version of the template.

If you think that sounds like something better handled there I can create one there

timelsass commented 5 years ago

yeah it seems like the check for tgmpa is included there, so it would make sense to have it in the https://github.com/WPTRT/WPThemeReview component

joyously commented 5 years ago

This seems out of scope. Themes shouldn't have template files that need updating.