search

WPTT / theme-sniffer

Theme Sniffer plugin using sniffs.
MIT License
270 stars 3 forks source link

Look into changing name display in dropdown #127

Open timelsass opened 5 years ago

timelsass commented 5 years ago

@dingo-d did a fresh install and ran build, everything tests out fine so far. One thing I noticed with multiple themes named the same in the dropdown - the calls for version and which is the active theme are I guess pulled from wp_get_theme - so they all remain the same. I looked at Theme Check, and it looks like it was resolved by naming duplicates as Theme Name/folder-name. I don't think that's a blocker though.

Originally posted by @timelsass in https://github.com/WPTRT/theme-sniffer/pull/125#issuecomment-469242495

dingo-d commented 5 years ago

Should we go with this? As currently the version is added to the theme name.

timelsass commented 5 years ago

The issue still exists, but it probably doesn't impact many people, more of a "would be nice" to help identify when you might have multiple of the same theme added, just they have renamed folders. The other part of this is say you copy/paste a theme folder a few times - running a scan right now - I believe the dropdown is relying on the theme's slug. Regardless of which option you choose, the slug is the same, so it only ever runs on the one main theme folder, which can be confusing if you're temporarily renaming a folder to make/test changes.