search

WPTT / theme-sniffer

Theme Sniffer plugin using sniffs.
MIT License
269 stars 3 forks source link

The ignore annotations option does contrary to what it says #164

Closed vladolaru closed 5 years ago

vladolaru commented 5 years ago

Right now, when the checkbox is unchecked it will NOT ignore annotations and when it is checked it will ignore them.

This is due to the fact that PHPCS's runner config option annotations is used to declare if annotations should be taken into account (true by default), while the plugin option is opposite in declaring if they should be ignored (false by default).

The line in question is this one: https://github.com/WPTRT/theme-sniffer/blob/development/src/callback/class-run-sniffer-callback.php#L576. We should simply negate the $ignore_annotations variable.

Related issue: https://github.com/WPTRT/theme-sniffer/issues/84

dingo-d commented 5 years ago

Thanks for the bug report, I hope to have the next version with the fix out soon 🙂

vladolaru commented 5 years ago

I'm glad I could help out. Keep up the great work 💪